Skip to content

Specify the maximum number of fireworks to start #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Specify the maximum number of fireworks to start #117

wants to merge 1 commit into from

Conversation

aaron13100
Copy link

This is different than launch() because it respects the delay (whereas launch() just does everything at once).

Feel free to not accept this or change it however you like. I haven't tested it at all as the changes I made were in JavaScript and I can't get the project to build/work with typescript.

Checklist

@aaron13100
Specify the number of fireworks to start
f3c0bb2 
This is different than launch() because it respects the delay (whereas launch() just does everything at once).

Feel free to not accept this or change it however you like. I haven't tested it at all as the changes I made were in JavaScript and I can't get the project to build/work with typescript.
@crashmax-dev
Copy link
Owner

@aaron13100 you misunderstand me. 😄

i mean about this:

  • use my own function to play audio so I can adjust the volume and follow whether it's playing or not.
  • wait to load the audioContext until initTrace() so there's no warning about missing user interaction in Firefox.

currently implemented like this:

fireworks-js/packages/fireworks-js/src/fireworks.ts

Lines 127 to 136 in 8c15ac0

launch(count = 1): void {
for (let i = 0; i < count; i++) {
this.createTrace()
}
if (!this.waitStopRaf) {
this.start()
this.waitStop()
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaron13100 @crashmax-dev